Issue 10823081: Resize control transfer buffers so users don't have to.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823081: Resize control transfer buffers so users don't have to. (Closed)

Created:
8 years, 4 months ago by Garret Kelly

Modified:
8 years, 4 months ago

Reviewers:
bryeung

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Resize control transfer buffers so users don't have to. The USB control transfer function assumed that a user would appropriately size their buffer in order to be able to contain the control transfer header. This has proved to be unnecessary, and this patch reallocates the transfer buffer with enough room for the control transfer setup. BUG=136812 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149278

Patch Set 1 #

Patch Set 2 : Fixing order bug. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/usb/usb_device.cc	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10823081/4001

8 years, 4 months ago (2012-07-31 20:02:05 UTC) #3

Change committed as 149278

Expand Messages | Collapse Messages