Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 10823080: contacts: Add GDataContactsServiceStub. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

contacts: Add GDataContactsServiceStub. This adds a stub implementation of GDataContactsServiceInterface to be used by (not-yet-checked-in) unit tests. BUG=128805 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149055

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
A chrome/browser/chromeos/gdata/gdata_contacts_service_stub.h View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_contacts_service_stub.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-07-30 15:49:36 UTC) #1
satorux1
LGTM
8 years, 4 months ago (2012-07-30 16:09:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10823080/4001
8 years, 4 months ago (2012-07-30 20:48:07 UTC) #3
commit-bot: I haz the power
Presubmit check for 10823080-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 20:48:19 UTC) #4
Daniel Erat
TBR ben for chrome/chrome_tests.gypi
8 years, 4 months ago (2012-07-30 20:49:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10823080/4001
8 years, 4 months ago (2012-07-30 20:50:16 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 22:24:46 UTC) #7
Change committed as 149055

Powered by Google App Engine
This is Rietveld 408576698