Issue 10823078: Add * to chrome/app/OWNERS to enable commit access to generated_resources.grd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823078: Add * to chrome/app/OWNERS to enable commit access to generated_resources.grd (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, zel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add * to chrome/app/OWNERS to enable commit access to generated_resources.grd BUG=none TEST=Adding new strings should not require LGTM from src/chrome/app owners Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148958

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/app/OWNERS	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

This is a follow up to our email exchange from last Thursday.

8 years, 4 months ago (2012-07-30 13:09:10 UTC) #1

Ben Goodger (Google)

8 years, 4 months ago (2012-07-30 15:53:26 UTC) #2

LGTM


On Mon, Jul 30, 2012 at 6:09 AM, <kaznacheev@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> This is a follow up to our email exchange from last Thursday.
>
> Description:
> Add * to chrome/app/OWNERS to enable commit access to
> generated_resources.grd
>
>
> BUG=none
> TEST=Adding new strings should not require LGTM from src/chrome/app owners
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10823078/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/app/OWNERS
>
>
> Index: chrome/app/OWNERS
> diff --git a/chrome/app/OWNERS b/chrome/app/OWNERS
> index 3aae3d6bec84794cf54872e4a57d40**f8d4e88fe3..**
> 19741dec1419133b2725d89265acae**7eaa811a59 100644
> --- a/chrome/app/OWNERS
> +++ b/chrome/app/OWNERS
> @@ -1 +1,4 @@
>  cpu@chromium.org
> +
> +# generated_resources.grd
> +*
>
>
>

Expand Messages | Collapse Messages