Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 10823074: Adding `chrome-extension` resources to the CSP relaxation documentation. (Closed)

Created:
8 years, 4 months ago by Mike West
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Adding `chrome-extension` resources to the CSP relaxation documentation. BUG=139443 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148934

Patch Set 1 #

Total comments: 1

Patch Set 2 : Thank Aaron. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M chrome/common/extensions/docs/extensions/contentSecurityPolicy.html View 1 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/static/contentSecurityPolicy.html View 1 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
This CL adds explicit mention of `chrome-extension` and `chrome-extension-resource` to the extension CSP relaxation documentation. ...
8 years, 4 months ago (2012-07-30 07:57:02 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/10823074/diff/1/chrome/common/extensions/docs/static/contentSecurityPolicy.html File chrome/common/extensions/docs/static/contentSecurityPolicy.html (right): http://codereview.chromium.org/10823074/diff/1/chrome/common/extensions/docs/static/contentSecurityPolicy.html#newcode234 chrome/common/extensions/docs/static/contentSecurityPolicy.html:234: not be accepted. <code>HTTPS</code>, on the other hand, ...
8 years, 4 months ago (2012-07-30 08:45:11 UTC) #2
Mike West
8 years, 4 months ago (2012-07-30 09:02:30 UTC) #3
On 2012/07/30 08:45:11, Aaron Boodman wrote:
> lgtm
> 
>
http://codereview.chromium.org/10823074/diff/1/chrome/common/extensions/docs/...
> File chrome/common/extensions/docs/static/contentSecurityPolicy.html (right):
> 
>
http://codereview.chromium.org/10823074/diff/1/chrome/common/extensions/docs/...
> chrome/common/extensions/docs/static/contentSecurityPolicy.html:234: not be
> accepted. <code>HTTPS</code>, on the other hand, secures the resources'
> I think it would be better to replace the last sentence with something like:
> 
> The currently allowed schemes are: https, chrome-extension, and
> chrome-extension-resources.

Done. I'll land this shortly.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698