Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 10823066: Don't log UDP receive failures in release (Closed)

Created:
8 years, 4 months ago by jschuh
Modified:
8 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Don't log UDP receive failures in release BUG=139819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149207

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ppapi/thunk/ppb_udp_socket_private_thunk.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jschuh
8 years, 4 months ago (2012-07-31 16:37:19 UTC) #1
jschuh
This is to prevent an OOM crash in Flapper. I'm still investigating the root cause ...
8 years, 4 months ago (2012-07-31 16:37:58 UTC) #2
viettrungluu
http://codereview.chromium.org/10823066/diff/1/ppapi/thunk/ppb_udp_socket_private_thunk.cc File ppapi/thunk/ppb_udp_socket_private_thunk.cc (right): http://codereview.chromium.org/10823066/diff/1/ppapi/thunk/ppb_udp_socket_private_thunk.cc#newcode54 ppapi/thunk/ppb_udp_socket_private_thunk.cc:54: #ifndef NDEBUG Why not #ifdef NDEBUG (reversing the contents ...
8 years, 4 months ago (2012-07-31 16:44:00 UTC) #3
viettrungluu
Also, is there a bug number for this? (Indicate in BUG= line.)
8 years, 4 months ago (2012-07-31 16:44:31 UTC) #4
jschuh
Added a bug for it and flipped the condition. http://codereview.chromium.org/10823066/diff/1/ppapi/thunk/ppb_udp_socket_private_thunk.cc File ppapi/thunk/ppb_udp_socket_private_thunk.cc (right): http://codereview.chromium.org/10823066/diff/1/ppapi/thunk/ppb_udp_socket_private_thunk.cc#newcode54 ppapi/thunk/ppb_udp_socket_private_thunk.cc:54: ...
8 years, 4 months ago (2012-07-31 16:55:17 UTC) #5
viettrungluu
8 years, 4 months ago (2012-07-31 16:56:03 UTC) #6
viettrungluu
8 years, 4 months ago (2012-07-31 16:57:19 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698