Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 10823063: Make h264_parser_unittest compilable under linux. (Closed)

Created:
8 years, 4 months ago by xiaomings
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make h264_parser_unittest compilable under linux. BUG= TEST=Compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148975

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix up dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/common/gpu/media/h264_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
xiaomings
Make h264_parser_unittest compilable under linux.
8 years, 4 months ago (2012-07-27 22:19:58 UTC) #1
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10823063/diff/1/content/content_tests.gypi File content/content_tests.gypi (right): https://chromiumcodereview.appspot.com/10823063/diff/1/content/content_tests.gypi#newcode729 content/content_tests.gypi:729: 'test_support_content', This is quite a large library; do you ...
8 years, 4 months ago (2012-07-27 22:25:23 UTC) #2
xiaomings
Dependency fixed up. test_support_content removed, base added.
8 years, 4 months ago (2012-07-27 23:51:27 UTC) #3
Pawel Osciak
lgtm
8 years, 4 months ago (2012-07-28 01:59:04 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-07-28 02:00:04 UTC) #5
Ami GONE FROM CHROMIUM
lgtm
8 years, 4 months ago (2012-07-28 20:57:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiaomings@google.com/10823063/3002
8 years, 4 months ago (2012-07-28 20:57:04 UTC) #7
commit-bot: I haz the power
Presubmit check for 10823063-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-28 20:57:13 UTC) #8
xiaomings
Hi John, Just need your LGTM for this. Thanks
8 years, 4 months ago (2012-07-29 02:07:49 UTC) #9
jam
lgtm feel free to TBR trivial changes to the gyp file like this
8 years, 4 months ago (2012-07-30 15:26:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiaomings@google.com/10823063/3002
8 years, 4 months ago (2012-07-30 16:44:17 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 18:08:06 UTC) #12
Change committed as 148975

Powered by Google App Engine
This is Rietveld 408576698