Issue 10823061: Revert 148792 - [Sync] Remove CleanupDisabledTypes command and move purge logic into SyncManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823061: Revert 148792 - [Sync] Remove CleanupDisabledTypes command and move purge logic into SyncManager. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov

Modified:
8 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 148792 - [Sync] Remove CleanupDisabledTypes command and move purge logic into SyncManager. We were only ever performing a meaningful cleanup on reconfigurations or restart, so we make that explicit by purging from within the SyncManager's loading and configuration methods. BUG=131433, 90868 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10541079 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148812

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -201 lines)			Patch
A +	sync/engine/cleanup_disabled_types_command.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sync/engine/cleanup_disabled_types_command.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sync/engine/cleanup_disabled_types_command_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	sync/engine/sync_scheduler_impl.cc	View	8 chunks	+43 lines, -0 lines	0 comments	Download
M	sync/engine/sync_scheduler_unittest.cc	View	8 chunks	+61 lines, -5 lines	0 comments	Download
M	sync/engine/syncer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/engine/syncer.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.cc	View	3 chunks	+1 line, -39 lines	0 comments	Download
M	sync/internal_api/syncapi_unittest.cc	View	7 chunks	+9 lines, -153 lines	0 comments	Download
M	sync/sessions/sync_session_context.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	sync/sync.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)