Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10823059: Revert revert of 146149 - Don't pass the connector check policy along. (Closed)

Created:
8 years, 4 months ago by Scott Byer
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert revert of 146149 - Don't pass the connector check policy along. Continuation of http://codereview.chromium.org/10692178/ If a browser is running, and the service process is running the connector, the connector will occasionally start up a chromium process to check the connector enablement policy. The flag to do so would get passed to a running browser, if present, and there is a path through the policy check code that could cause the browser to quit. This patch prevents the policy check flag from being passed on; the started process will be very short lived and does a silent launch. Original Review URL: https://chromiumcodereview.appspot.com/10666010 Second Review URL: http://codereview.chromium.org/10692178/ BUG=134252 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148872

Patch Set 1 #

Patch Set 2 : Catch up with timeout method rename. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -4 lines) Patch
M chrome/browser/chrome_browser_main.cc View 3 chunks +11 lines, -4 lines 0 comments Download
A chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_result_codes.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Byer
Try, try again... A method rename crossed 10692178 in the CQ.
8 years, 4 months ago (2012-07-27 20:30:15 UTC) #1
Albert Bodenhamer
lgtm
8 years, 4 months ago (2012-07-27 20:37:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/10823059/1005
8 years, 4 months ago (2012-07-27 21:07:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 10823059-1005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-27 21:08:01 UTC) #4
Lei Zhang
lgtm
8 years, 4 months ago (2012-07-28 00:26:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/10823059/1005
8 years, 4 months ago (2012-07-28 00:26:45 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-28 02:18:14 UTC) #7
Change committed as 148872

Powered by Google App Engine
This is Rietveld 408576698