Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 10823057: Prevent the Ctrl+Alt+E shortcut from cancelling from the normal enrollment screen too. (Closed)

Created:
8 years, 4 months ago by Joao da Silva
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Prevent the Ctrl+Alt+E shortcut from cancelling from the normal enrollment screen too. BUG=chromium-os:31897 TEST=Go into the manual enrollment screen by pressing Ctrl+Alt+E from the sign-in screen. Pressing Ctrl+Alt+E does NOT show a cancel dialog about auto enrollment. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
Hi Ivan, we let this little bug slip through in https://chromiumcodereview.appspot.com/10694099. Please review, thanks!
8 years, 4 months ago (2012-07-27 15:36:18 UTC) #1
Joao da Silva
Friendly ping :-) @Nikita: maybe Ivan is not available, can you review this?
8 years, 4 months ago (2012-07-31 09:45:24 UTC) #2
Ivan Korotkov
Oops, I'm sorry. LGTM
8 years, 4 months ago (2012-07-31 16:35:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10823057/1
8 years, 4 months ago (2012-07-31 16:55:08 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 19:39:59 UTC) #5
Change committed as 149242

Powered by Google App Engine
This is Rietveld 408576698