Issue 10823047: ash: Fix a tyop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823047: ash: Fix a tyop. (Closed)

Created:
8 years, 5 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Fix a tyop. BUG=138643 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148663

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ash/wm/system_gesture_event_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 4 months ago (2012-07-26 22:37:29 UTC) #2

LGTM


On Thu, Jul 26, 2012 at 2:02 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> ash: Fix a tyop.
>
> BUG=138643
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/10823047/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ash/wm/system_gesture_event_**filter.cc
>
>
> Index: ash/wm/system_gesture_event_**filter.cc
> diff --git a/ash/wm/system_gesture_event_**filter.cc
> b/ash/wm/system_gesture_event_**filter.cc
> index 4d19efd376d4fade92d90dc491d4dc**7b3d43a550..**
> eda91420ec7873be51b57244cdfb89**4e1468dee6 100644
> --- a/ash/wm/system_gesture_event_**filter.cc
> +++ b/ash/wm/system_gesture_event_**filter.cc
> @@ -616,7 +616,7 @@ ui::GestureStatus SystemGestureEventFilter::**
> PreHandleGestureEvent(
>          event->details().touch_points(**) == kSystemGesturePoints) {
>        ash::AcceleratorController* accelerator =
>            ash::Shell::GetInstance()->**accelerator_controller();
> -      if (accelerator->PerformAction(**CYCLE_BACKWARD_MRU,
> ui::Accelerator()))
> +      if (accelerator->PerformAction(**CYCLE_FORWARD_MRU,
> ui::Accelerator()))
>          return ui::GESTURE_STATUS_CONSUMED;
>      }
>      return ui::GESTURE_STATUS_UNKNOWN;
>
>
>

Expand Messages | Collapse Messages