Issue 10823044: [chromeos] Update expected name of remoting plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823044: [chromeos] Update expected name of remoting plugin (Closed)

Created:
8 years, 5 months ago by Nirnimesh

Modified:
8 years, 5 months ago

Reviewers:
krisr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromeos] Update expected name of remoting plugin R=krisr@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148595

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/data/chromeos_plugins_list.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

krisr

8 years, 5 months ago (2012-07-26 18:39:44 UTC) #2

LGTM


On Thu, Jul 26, 2012 at 11:36 AM, <nirnimesh@chromium.org> wrote:

> Reviewers: krisr,
>
> Description:
> [chromeos] Update expected name of remoting plugin
>
>
> R=krisr@chromium.org
> BUG=
> TEST=
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10823044/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/test/data/chromeos_**plugins_list.txt
>
>
> Index: chrome/test/data/chromeos_**plugins_list.txt
> diff --git a/chrome/test/data/chromeos_**plugins_list.txt
> b/chrome/test/data/chromeos_**plugins_list.txt
> index f45aaac296488d8b74051b22313e86**405b802fa8..**
> 15964ebfb0f8ef538b53b0b90e56f7**e703d285be 100644
> --- a/chrome/test/data/chromeos_**plugins_list.txt
> +++ b/chrome/test/data/chromeos_**plugins_list.txt
> @@ -7,7 +7,7 @@
>    }, {
>      u'boards': ['x86-mario', 'x86-alex', 'x86-zgb', 'stumpy', 'lumpy'],
>      u'enabled': 1,
> -    u'name': 'Remoting Viewer',
> +    u'name': 'Chrome Remote Desktop Viewer',
>      u'version': u''
>    }, {
>      u'boards': ['x86-mario', 'x86-alex', 'x86-zgb', 'stumpy', 'lumpy'],
>
>
>

Expand Messages | Collapse Messages