Issue 10823036: Added/changed some strings for the Files app

Issue 10823036: Added/changed some strings for the Files app (Closed)

Created:
8 years, 5 months ago by Vladislav Kaznacheev

Modified:
8 years, 4 months ago

Reviewers:
Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added/changed some strings for the Files app BUG=131492, 137055, 137596, 137987 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149162

Patch Set 2 : Rebased, removed one of the strings #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	chrome/app/generated_resources.grd	View		4 chunks	+15 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dmitry Zvorygin

LGTM, but please take a look at notice. http://codereview.chromium.org/10823036/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10823036/diff/1/chrome/app/generated_resources.grd#newcode10894 chrome/app/generated_resources.grd:10894: + ...

8 years, 5 months ago (2012-07-26 13:48:39 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10823036/1

8 years, 5 months ago (2012-07-26 14:47:34 UTC) #6

commit-bot: I haz the power

8 years, 5 months ago (2012-07-26 14:47:40 UTC) #7

Presubmit check for 10823036-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/app

Presubmit checks took 1.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages