Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1082303004: Remove ICS check in BookmarkUtil. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
Yaron, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ICS check in BookmarkUtil. This CL also add OWNERS file for ApiCompatibilityUtils BUG=473837 Committed: https://crrev.com/847524c671d6ae395603b25ae99f907ef9678c1c Cr-Commit-Position: refs/heads/master@{#327163}

Patch Set 1 #

Patch Set 2 : Add api compat utils #

Patch Set 3 : Add OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 1 chunk +12 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java View 1 3 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-21 23:29:07 UTC) #2
newt (away)
lgtm
5 years, 8 months ago (2015-04-21 23:59:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082303004/1
5 years, 8 months ago (2015-04-22 00:04:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/14591)
5 years, 8 months ago (2015-04-22 01:27:34 UTC) #7
aurimas (slooooooooow)
yfriedman: PTAL at changes in base/
5 years, 8 months ago (2015-04-27 20:00:58 UTC) #9
Yaron
On 2015/04/27 20:00:58, aurimas wrote: > yfriedman: PTAL at changes in base/ lgtm
5 years, 8 months ago (2015-04-27 22:03:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082303004/40001
5 years, 8 months ago (2015-04-27 22:03:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-27 22:56:40 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 22:57:33 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/847524c671d6ae395603b25ae99f907ef9678c1c
Cr-Commit-Position: refs/heads/master@{#327163}

Powered by Google App Engine
This is Rietveld 408576698