Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 10823020: Remove the part of generating xkeyboard_data.h from gen_keyboard_overlay_data.py. (Closed)

Created:
8 years, 5 months ago by mazda
Modified:
8 years, 5 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Remove the part of generating xkeyboard_data.h from gen_keyboard_overlay_data.py. xkeyboard_data.h is no longer necessary. BUG=None TEST=The scripts runs as before Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -69 lines) Patch
M tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py View 8 chunks +5 lines, -69 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mazda
8 years, 5 months ago (2012-07-25 20:39:56 UTC) #1
Yusuke Sato
lgtm, thanks.
8 years, 5 months ago (2012-07-25 21:28:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10823020/1
8 years, 5 months ago (2012-07-25 21:31:51 UTC) #3
commit-bot: I haz the power
Try job failure for 10823020-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-25 22:00:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10823020/1
8 years, 5 months ago (2012-07-25 22:22:45 UTC) #5
commit-bot: I haz the power
Try job failure for 10823020-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-25 23:34:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10823020/1
8 years, 5 months ago (2012-07-26 01:24:54 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 03:13:25 UTC) #8
Change committed as 148501

Powered by Google App Engine
This is Rietveld 408576698