ppapi/native_client/src/trusted/plugin/service_runtime.h - Issue 10823019: Ensure that errors that occur during load will get crash log info to JS console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/service_runtime.h

Issue 10823019: Ensure that errors that occur during load will get crash log info to JS console (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: code review based changes Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/native_client/src/trusted/plugin/service_runtime.h

diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.h b/ppapi/native_client/src/trusted/plugin/service_runtime.h

index 5af0c5183d76257937e8618d9efc11431d5d5e87..54829ef3c98b0ec46c0a12c479f762516a35de96 100644

--- a/ppapi/native_client/src/trusted/plugin/service_runtime.h

+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.h

@@ -219,7 +219,8 @@ class ServiceRuntime {

// describing the error.

bool Start(nacl::DescWrapper* nacl_file_desc,

ErrorInfo* error_info,

- const nacl::string& url);

+ const nacl::string& url,

+ pp::CompletionCallback crash_cb);

// Starts the application channel to the nexe.

SrpcClient* SetupAppChannel();

« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.cc ('k') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('j') | no next file with comments »