Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 10823017: Revert 148383 - Move the keyboard overlay view to ash. (Closed)

Created:
8 years, 5 months ago by Ryan Hamilton
Modified:
8 years, 5 months ago
Reviewers:
mazda
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 148383 - Move the keyboard overlay view to ash. This change introduces an issue when Shift+Alt is pressed (http://code.google.com/p/chromium/issues/detail?id=131159). I'll fix it shortly together with the more general issue (http://code.google.com/p/chromium/issues/detail?id=129834). BUG=124222 TEST=None Review URL: https://chromiumcodereview.appspot.com/10829003 TBR=mazda@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -304 lines) Patch
M ash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +0 lines, -4 lines 0 comments Download
D ash/keyboard_overlay/keyboard_overlay_delegate.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ash/keyboard_overlay/keyboard_overlay_delegate.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D ash/keyboard_overlay/keyboard_overlay_view.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ash/keyboard_overlay/keyboard_overlay_view.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 3 chunks +2 lines, -6 lines 0 comments Download
A + chrome/browser/ui/views/keyboard_overlay_delegate.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/keyboard_overlay_delegate.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/keyboard_overlay_dialog_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/keyboard_overlay_dialog_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Hamilton
8 years, 5 months ago (2012-07-25 19:53:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698