Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10823016: [NaCl SDK] Don't copy .h files to src in SDK. (Closed)

Created:
8 years, 5 months ago by binji
Modified:
8 years, 5 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[NaCl SDK] Don't copy .h files to src in SDK. build_sdk.py: Also added --libraries to build only libraries. generate_make.py: Added HEADERS tag and HEADERS_DEST to .dsc file to allow a library to specify public headers and a place to install them. BUG=none TEST=none R=noelallen@chromium.org NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148455

Patch Set 1 #

Total comments: 6

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -50 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 1 4 chunks +24 lines, -9 lines 0 comments Download
M native_client_sdk/src/build_tools/make_rules.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 chunk +0 lines, -35 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_gles2/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/pthread/library.dsc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
8 years, 5 months ago (2012-07-25 19:05:52 UTC) #1
noelallen1
http://codereview.chromium.org/10823016/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): http://codereview.chromium.org/10823016/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode696 native_client_sdk/src/build_tools/build_sdk.py:696: parser.add_option('--libraries', help='Only build the libraries.', note: I think this ...
8 years, 5 months ago (2012-07-25 20:36:03 UTC) #2
noelallen1
Per our discussion, fold in library. LGTM.
8 years, 5 months ago (2012-07-25 21:05:35 UTC) #3
binji
http://codereview.chromium.org/10823016/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): http://codereview.chromium.org/10823016/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode696 native_client_sdk/src/build_tools/build_sdk.py:696: parser.add_option('--libraries', help='Only build the libraries.', On 2012/07/25 20:36:03, noelallen1 ...
8 years, 5 months ago (2012-07-25 21:13:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10823016/9001
8 years, 5 months ago (2012-07-25 23:32:05 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 00:54:34 UTC) #6
Change committed as 148455

Powered by Google App Engine
This is Rietveld 408576698