Issue 10823008: [mac] In app windows, calculate the window corner radius programmatically.

Issue 10823008: [mac] In app windows, calculate the window corner radius programmatically. (Closed)

Created:
8 years, 5 months ago by jeremya

Modified:
8 years, 5 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, jbates

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[mac] In app windows, calculate the rounded corner radius programmatically. R=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148458

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm	View	1	1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

https://chromiumcodereview.appspot.com/10823008/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right): https://chromiumcodereview.appspot.com/10823008/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm#newcode62 chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:62: - (float)roundedCornerRadius; This probably returns CGFloat https://chromiumcodereview.appspot.com/10823008/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm#newcode73 chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:73: float ...

8 years, 5 months ago (2012-07-25 23:25:36 UTC) #2

jeremya

Copying browser/ui/cocoa/framed_browser_window.mm :) https://chromiumcodereview.appspot.com/10823008/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right): https://chromiumcodereview.appspot.com/10823008/diff/1/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm#newcode62 chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:62: - (float)roundedCornerRadius; On 2012/07/25 23:25:36, rsesek ...

8 years, 5 months ago (2012-07-25 23:36:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10823008/5001

8 years, 5 months ago (2012-07-25 23:40:50 UTC) #5

Change committed as 148458

Expand Messages | Collapse Messages