Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: ui/views/controls/button/menu_button.cc

Issue 10823004: Consume TAP regardless of menu result to avoid setting HOT state in CustomButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Return unknown status after showing blocking menu. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/menu_button.cc
diff --git a/ui/views/controls/button/menu_button.cc b/ui/views/controls/button/menu_button.cc
index 23607f4eb56b4279bd1c44c6c31b9077279c5eed..fe33e35bf391f815c664ae64227922758dfee773 100644
--- a/ui/views/controls/button/menu_button.cc
+++ b/ui/views/controls/button/menu_button.cc
@@ -224,6 +224,7 @@ ui::GestureStatus MenuButton::OnGestureEvent(const GestureEvent& event) {
if (state() != BS_DISABLED && event.type() == ui::ET_GESTURE_TAP) {
if (Activate())
return ui::GESTURE_STATUS_CONSUMED;
+ return ui::GESTURE_STATUS_UNKNOWN;
}
return TextButton::OnGestureEvent(event);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698