Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 10823003: Merge 123180 - Introduce Node::shadowHost() (Closed)

Created:
8 years, 5 months ago by tkent
Modified:
8 years, 5 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 123180 - Introduce Node::shadowHost() https://bugs.webkit.org/show_bug.cgi?id=91814 Reviewed by Hajime Morita. Introduce Node::shadowHost(), which return the host element, or 0. Node::shadowAncestorNode() is used to obtain a shadow host. However it is confusing because it returns 'this' if this is not in a shadow tree. Replaces one callsite of shadowAncestorNode() with shadowHost(). No behavior change. * dom/Node.cpp: (WebCore::Node::shadowHost): Added. * dom/Node.h: (Node): Declare shadowHost(), and add a comment to shadowAncestorNode(). * html/shadow/CalendarPickerElement.cpp: (WebCore::CalendarPickerElement::hostInput): Replace shadowAncestorNode() with shaodwHost(). TBR=tkent@chromium.org BUG=crbug.com/136145 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M Source/WebCore/dom/Node.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Node.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebCore/html/shadow/CalendarPickerElement.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
8 years, 5 months ago (2012-07-24 23:34:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698