Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(57)

Issue 10822029: Use EXT_robustness where available on GLES2 platforms to detect and respond to resets of the graphi… (Closed)

Created:
6 years, 12 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 11 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, greggman
Visibility:
Public.

Description

Use EXT_robustness where available on GLES2 platforms to detect and respond to resets of the graphics card. BUG=138162 TEST=ran https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/conformance-suites/1.0.1/extra/slow-shader-example.html on Windows with ANGLE and verified that new code path was taken Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148721

Patch Set 1 #

Patch Set 2 : Fixed GL interface mock. #

Total comments: 3

Patch Set 3 : Addressed review feedback. Rebuilt and re-tested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -28 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/khronos/EGL/eglext.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gl/generate_bindings.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_context.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_egl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_context_egl.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M ui/gl/gl_context_glx.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_fence.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 12 months ago (2012-07-26 01:21:31 UTC) #1
Ken Russell (switch to Gerrit)
Please review. Thanks.
6 years, 12 months ago (2012-07-26 22:03:48 UTC) #2
apatrick_chromium
lgtm https://chromiumcodereview.appspot.com/10822029/diff/8001/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://chromiumcodereview.appspot.com/10822029/diff/8001/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode8541 gpu/command_buffer/service/gles2_cmd_decoder.cc:8541: status = glGetGraphicsResetStatusARB(); You could make ARB alias ...
6 years, 12 months ago (2012-07-26 22:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/10822029/12002
6 years, 12 months ago (2012-07-27 02:09:48 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2012-07-27 04:59:31 UTC) #5
Change committed as 148721

Powered by Google App Engine
This is Rietveld 408576698