Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: media/filters/chunk_demuxer.cc

Issue 10822024: Don't clear the list of source buffers in ChunkDemuxer::Shutdown() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for mem leak Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/chunk_demuxer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.cc
diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc
index e28a2d313062f98d03e01817df9ba54d39e2db9c..c548467504824a96e2c63e3fa6353511255c1f2e 100644
--- a/media/filters/chunk_demuxer.cc
+++ b/media/filters/chunk_demuxer.cc
@@ -655,7 +655,7 @@ ChunkDemuxer::Status ChunkDemuxer::AddId(const std::string& id,
CHECK(stream_parser.get());
stream_parser->Init(
- base::Bind(&ChunkDemuxer::OnStreamParserInitDone, this),
+ base::Bind(&ChunkDemuxer::OnStreamParserInitDone, base::Unretained(this)),
base::Bind(&ChunkDemuxer::OnNewConfigs, base::Unretained(this),
has_audio, has_video),
audio_cb,
@@ -857,12 +857,6 @@ void ChunkDemuxer::Shutdown() {
if (video_)
video_->Shutdown();
- for (StreamParserMap::iterator it = stream_parser_map_.begin();
- it != stream_parser_map_.end(); ++it) {
- delete it->second;
- }
- stream_parser_map_.clear();
-
ChangeState_Locked(SHUTDOWN);
}
« no previous file with comments | « no previous file | media/filters/chunk_demuxer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698