Refactor invocation emission.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 786 matching lines @@
 
     if self._interface.id == 'CSSStyleDeclaration' and node.id == 'setProperty':
       # CSSStyleDeclaration.setProperty priority parameter is optional in Dart
       # idl, but is not optional in webcore implementation.
       if len(arguments) == 2:
         cpp_arguments.append('String()')
 
     if 'NeedsUserGestureCheck' in ext_attrs:
       cpp_arguments.append('DartUtilities::processingUserGesture');
 
-    invocation = self._GenerateWebCoreInvocation(
-        function_expression, cpp_arguments, return_type, ext_attrs, raises_dom_exception)
+    invocation_emitter = head_emitter
+    if raises_dom_exception:
+      cpp_arguments.append('ec')
+      invocation_emitter = head_emitter.Emit(
+        '        ExceptionCode ec = 0;\n'
+        '$!INVOCATION'
+        '        if (UNLIKELY(ec)) {\n'
+        '            exception = DartDOMWrapper::exceptionCodeToDartException(ec);\n'
+        '            goto fail;\n'
+        '        }\n')
+
+    function_call = '%s(%s)' % (function_expression, ', '.join(cpp_arguments))
+    if return_type == 'void':
+      invocation_emitter.Emit(
+        '        $FUNCTION_CALL;\n',
+        FUNCTION_CALL=function_call)
+    else:
+      return_type_info = self._TypeInfo(return_type)
+      self._cpp_impl_includes |= set(return_type_info.conversion_includes())
+
+      # Generate to Dart conversion of C++ value.
+      to_dart_conversion = return_type_info.to_dart_conversion(function_call, self._interface.id, ext_attrs)
+      invocation_emitter.Emit(
+        '        Dart_Handle returnValue = $TO_DART_CONVERSION;\n'
+        '        if (returnValue)\n'
+        '            Dart_SetReturnValue(args, returnValue);\n',
+        TO_DART_CONVERSION=to_dart_conversion)
 
     body = emitter.Format(
         '    {\n'
         '$HEAD'
-        '$INVOCATION'
         '        return;\n'
         '    }\n',
-        HEAD=head_emitter.Fragments(),
-        INVOCATION=invocation)
+        HEAD=head_emitter.Fragments())
 
     if raises_exceptions:
       body = emitter.Format(
           '    Dart_Handle exception = 0;\n'
           '$BODY'
           '\n'
           'fail:\n'
           '    Dart_ThrowException(exception);\n'
           '    ASSERT_NOT_REACHED();\n',
           BODY=body)
@@ skipping 58 matching lines @@
     attribute_name = attr.ext_attrs['Reflect'] or attr.id.lower()
     return 'WebCore::%s::%sAttr' % (namespace, attribute_name)
 
   def _GenerateWebCoreFunctionExpression(self, function_name, idl_node):
     if 'ImplementedBy' in idl_node.ext_attrs:
       return '%s::%s' % (idl_node.ext_attrs['ImplementedBy'], function_name)
     if idl_node.is_static:
       return '%s::%s' % (self._interface_type_info.idl_type(), function_name)
     return '%s%s' % (self._interface_type_info.receiver(), function_name)
 
-  def _GenerateWebCoreInvocation(self, function_expression, arguments,
-      idl_return_type, attributes, raises_dom_exceptions):
-    invocation_template = '        $FUNCTION_CALL;\n'
-    if idl_return_type != 'void':
-      return_type_info = self._TypeInfo(idl_return_type)
-      self._cpp_impl_includes |= set(return_type_info.conversion_includes())
-
-      # Generate to Dart conversion of C++ value.
-      to_dart_conversion = return_type_info.to_dart_conversion('$FUNCTION_CALL', self._interface.id, attributes)
-      invocation_template = emitter.Format(
-          '        Dart_Handle returnValue = $TO_DART_CONVERSION;\n'
-          '        if (returnValue)\n'
-          '            Dart_SetReturnValue(args, returnValue);\n',
-          TO_DART_CONVERSION=to_dart_conversion)
-
-    if raises_dom_exceptions:
-      # Add 'ec' argument to WebCore invocation and convert DOM exception to Dart exception.
-      arguments.append('ec')
-      invocation_template = emitter.Format(
-          '        ExceptionCode ec = 0;\n'
-          '$INVOCATION'
-          '        if (UNLIKELY(ec)) {\n'
-          '            exception = DartDOMWrapper::exceptionCodeToDartException(ec);\n'
-          '            goto fail;\n'
-          '        }\n',
-          INVOCATION=invocation_template)
-
-    return emitter.Format(invocation_template,
-        FUNCTION_CALL='%s(%s)' % (function_expression, ', '.join(arguments)))
-
   def _TypeInfo(self, type_name):
     return self._system._type_registry.TypeInfo(type_name)
 
 
 def _GenerateCPPIncludes(includes):
   return ''.join(['#include %s\n' % include for include in sorted(includes)])
 
 def _FindInHierarchy(database, interface, test):
   if test(interface):
     return interface
   for parent in interface.parents:
     parent_name = parent.type.id
     if not database.HasInterface(parent.type.id):
       continue
     parent_interface = database.GetInterface(parent.type.id)
     parent_interface = _FindInHierarchy(database, parent_interface, test)
     if parent_interface:
       return parent_interface
 
 def _IsArgumentOptionalInWebCore(argument):
   return IsOptional(argument) and not 'Callback' in argument.ext_attrs
 
 def _ToWebKitName(name):
   name = name[0].lower() + name[1:]
   name = re.sub(r'^(hTML|uRL|jS|xML|xSLT)', lambda s: s.group(1).lower(),
                 name)
   return re.sub(r'^(create|exclusive)', lambda s: 'is' + s.group(1).capitalize(),
                 name)