Issue 108213010: Docserver: Add per-request profiling.

Issue 108213010: Docserver: Add per-request profiling. (Closed)

Created:
7 years ago by not at google - send to devlin

Modified:
7 years ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Docserver: Add per-request profiling. R=yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240544

Patch Set 2 : add github crash thing #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -11 lines)			Patch
M	chrome/common/extensions/docs/server2/app.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/app_engine_handler.py	View		1 chunk	+24 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/github_file_system.py	View	1	1 chunk	+6 lines, -2 lines	2 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

Docserver is really slow right now. Adding profiling.

7 years ago (2013-12-12 22:34:21 UTC) #1

Yoyo Zhou

LGTM https://chromiumcodereview.appspot.com/108213010/diff/1/chrome/common/extensions/docs/server2/app_engine_handler.py File chrome/common/extensions/docs/server2/app_engine_handler.py (right): https://chromiumcodereview.appspot.com/108213010/diff/1/chrome/common/extensions/docs/server2/app_engine_handler.py#newcode31 chrome/common/extensions/docs/server2/app_engine_handler.py:31: self.response.out.write(s.getvalue()) I assume you're not concerned that the ...

7 years ago (2013-12-13 02:18:47 UTC) #2

not at google - send to devlin

https://chromiumcodereview.appspot.com/108213010/diff/1/chrome/common/extensions/docs/server2/app_engine_handler.py File chrome/common/extensions/docs/server2/app_engine_handler.py (right): https://chromiumcodereview.appspot.com/108213010/diff/1/chrome/common/extensions/docs/server2/app_engine_handler.py#newcode31 chrome/common/extensions/docs/server2/app_engine_handler.py:31: self.response.out.write(s.getvalue()) On 2013/12/13 02:18:47, Yoyo Zhou wrote: > I ...

7 years ago (2013-12-13 03:23:35 UTC) #3

not at google - send to devlin

I had to sneak another fix in here because the server kept on burning a ...

7 years ago (2013-12-13 03:35:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/108213010/20001

7 years ago (2013-12-13 03:37:05 UTC) #5

Yoyo Zhou

still LGTM https://codereview.chromium.org/108213010/diff/20001/chrome/common/extensions/docs/server2/github_file_system.py File chrome/common/extensions/docs/server2/github_file_system.py (right): https://codereview.chromium.org/108213010/diff/20001/chrome/common/extensions/docs/server2/github_file_system.py#newcode106 chrome/common/extensions/docs/server2/github_file_system.py:106: except: except SpecificTypeOfError: would be better.

7 years ago (2013-12-13 05:15:20 UTC) #6

not at google - send to devlin

7 years ago (2013-12-18 02:26:11 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/108213010/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/github_file_system.py (right):

https://codereview.chromium.org/108213010/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/github_file_system.py:106: except:
On 2013/12/13 05:15:21, Yoyo Zhou wrote:
> except SpecificTypeOfError: would be better.

Done.

Expand Messages | Collapse Messages