Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 10821134: Fix clang error with inlined function on Android. (Closed)

Created:
8 years, 4 months ago by no sievers
Modified:
8 years, 4 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix clang error with inlined function on Android. BUG=136923 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/android/draw_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/draw_delegate_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
no sievers
yea, we're not building Android with clang upstream.
8 years, 4 months ago (2012-08-01 18:24:16 UTC) #1
no sievers
8 years, 4 months ago (2012-08-01 18:24:28 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-01 18:24:41 UTC) #3
Ted C
lgtm
8 years, 4 months ago (2012-08-01 18:26:19 UTC) #4
Yaron
lgtm
8 years, 4 months ago (2012-08-01 18:29:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/10821134/1
8 years, 4 months ago (2012-08-01 18:29:48 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 19:53:51 UTC) #7
Change committed as 149474

Powered by Google App Engine
This is Rietveld 408576698