Introduce the --sdk-build flag for Android's native test generator

Introduce the --sdk-build flag for Android's native test generator

This flag supersedes --ant-compile and takes its value from gyp's sdk_build
variable. It will tell the native test generator script to use Ant for Java
compilation (default) instead of the Android.mk file.
    
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149440

[bulach, 2012-08-01 12:49:56]

one suggestion below:

https://chromiumcodereview.appspot.com/10821128/diff/1/build/apk_test.gypi
File build/apk_test.gypi (right):

https://chromiumcodereview.appspot.com/10821128/diff/1/build/apk_test.gypi#ne...
build/apk_test.gypi:50: '--ant-compile=<(sdk_build)'
this is a bit confusing.. since this is the only place setting this option, it'd
be better to rename from --ant-compile to --sdk-build.. the help text in the
python script will also be clearer.

[nilesh, 2012-08-01 13:49:43]

http://codereview.chromium.org/10821128/diff/1/testing/android/generate_nativ...
File testing/android/generate_native_test.py (right):

http://codereview.chromium.org/10821128/diff/1/testing/android/generate_nativ...
testing/android/generate_native_test.py:183: parser.add_option('--ant-compile',
type='int', default=0,
Maybe we should remove "--ant-compile" from DumpRenderTree_apk first and make
"ant_compile" the default here, to avoid breaking the build.

[Peter Beverloo, 2012-08-01 15:11:56]

Thank you for the reviews! See PS3.

https://chromiumcodereview.appspot.com/10821128/diff/1/build/apk_test.gypi
File build/apk_test.gypi (right):

https://chromiumcodereview.appspot.com/10821128/diff/1/build/apk_test.gypi#ne...
build/apk_test.gypi:50: '--ant-compile=<(sdk_build)'
On 2012/08/01 12:49:56, bulach wrote:
> this is a bit confusing.. since this is the only place setting this option,
it'd
> be better to rename from --ant-compile to --sdk-build.. the help text in the
> python script will also be clearer.

Agreed. I didn't change the help text, as I think it's accurate enough (together
with the parameter's name) as it is.

https://chromiumcodereview.appspot.com/10821128/diff/1/testing/android/genera...
File testing/android/generate_native_test.py (right):

https://chromiumcodereview.appspot.com/10821128/diff/1/testing/android/genera...
testing/android/generate_native_test.py:183: parser.add_option('--ant-compile',
type='int', default=0,
On 2012/08/01 13:49:43, nileshagrawal1 wrote:
> Maybe we should remove "--ant-compile" from DumpRenderTree_apk first and make
> "ant_compile" the default here, to avoid breaking the build.

By following Marcus' suggestion about renaming the flag and maintaining
redundancy until WebKit has been updated, we can avoid this. If/when this lands,
it'll roll into WebKit, we'll then update all users of --ant-compile to change
to --sdk-build (with the variable), and then submit a follow-up patch removing
this code on the Chromium side.

[bulach, 2012-08-01 15:26:49]

lgtm, thanks! truly minor nits:

https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
File testing/android/generate_native_test.py (right):

https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
testing/android/generate_native_test.py:184: help='If set to 1, build the
generated apk with ant. '
nit: very picky, but I think it's "If set to 0 => Android, otherwise ant"... I
mean, 2 would mean ant.. but yeah, incredibly picky.

https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
testing/android/generate_native_test.py:187: # FIXME(beverloo): Remove
--ant-compile when all users adopted.
 nit: I think TODO are far more common..

[Peter Beverloo, 2012-08-01 15:39:08]

Thank you! I'll wait for Nilesh' look as well.

https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
File testing/android/generate_native_test.py (right):

https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
testing/android/generate_native_test.py:184: help='If set to 1, build the
generated apk with ant. '
On 2012/08/01 15:26:49, bulach wrote:
> nit: very picky, but I think it's "If set to 0 => Android, otherwise ant"... I
> mean, 2 would mean ant.. but yeah, incredibly picky.

Yeah... I changed it to "Unless set to 0"...

https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
testing/android/generate_native_test.py:187: # FIXME(beverloo): Remove
--ant-compile when all users adopted.
On 2012/08/01 15:26:49, bulach wrote:
>  nit: I think TODO are far more common..

Sorry, WebKitism.

[nilesh, 2012-08-01 15:40:50]

On 2012/08/01 15:39:08, Peter Beverloo wrote:
> Thank you! I'll wait for Nilesh' look as well.

LGTM
> 
>
https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
> File testing/android/generate_native_test.py (right):
> 
>
https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
> testing/android/generate_native_test.py:184: help='If set to 1, build the
> generated apk with ant. '
> On 2012/08/01 15:26:49, bulach wrote:
> > nit: very picky, but I think it's "If set to 0 => Android, otherwise ant"...
I
> > mean, 2 would mean ant.. but yeah, incredibly picky.
> 
> Yeah... I changed it to "Unless set to 0"...
> 
>
https://chromiumcodereview.appspot.com/10821128/diff/6001/testing/android/gen...
> testing/android/generate_native_test.py:187: # FIXME(beverloo): Remove
> --ant-compile when all users adopted.
> On 2012/08/01 15:26:49, bulach wrote:
> >  nit: I think TODO are far more common..
> 
> Sorry, WebKitism.

[commit-bot: I haz the power, 2012-08-01 15:58:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/10821128/9003

[commit-bot: I haz the power, 2012-08-01 17:39:25]

Change committed as 149440