Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 10821121: sync: Attempt to recover from directory corruption (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix other win compile warning Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/syncable/directory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index bc72dccfedc196a0bc60af76bf7b8da5b975e4c9..ca3926fc6acb27490d83a7f577754ec6b2792c48 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -700,6 +700,13 @@ void ProfileSyncService::OnBackendInitialized(
// Keep the directory around for now so that on restart we will retry
// again and potentially succeed in presence of transient file IO failures
// or permissions issues, etc.
+ //
+ // TODO(rlarocque): Consider making this UnrecoverableError less special.
+ // Unlike every other UnrecoverableError, it does not delete our sync data.
+ // This exception made sense at the time it was implemented, but our new
+ // directory corruption recovery mechanism makes it obsolete. By the time
+ // we get here, we will have already tried and failed to delete the
+ // directory. It would be no big deal if we tried to delete it again.
OnInternalUnrecoverableError(FROM_HERE,
"BackendInitialize failure",
false,
« no previous file with comments | « no previous file | sync/syncable/directory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698