Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 10821118: Bump DEPS and use new download_toolchains.py in NaCl Repo. (Closed)

Created:
8 years, 4 months ago by noelallen1
Modified:
8 years, 4 months ago
Reviewers:
bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Bump DEPS and use new download_toolchains.py in NaCl Repo. Remove hashes from DEPS file and instead use the ones specified in the NaCl repo for the version of NativeClient specified in the DEPS file. BUG=http://code.google.com/p/chromium/issues/detail?id=138285 TBR= bradnelson@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149360

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -54 lines) Patch
M DEPS View 1 2 2 chunks +1 line, -53 lines 0 comments Download
M build/download_nacl_toolchains.py View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
lgtm http://codereview.chromium.org/10821118/diff/1/build/download_nacl_toolchains.py File build/download_nacl_toolchains.py (right): http://codereview.chromium.org/10821118/diff/1/build/download_nacl_toolchains.py#newcode52 build/download_nacl_toolchains.py:52: args.append(os.path.join(nacl_dir,"TOOL_REVISIONS")) single quotes to match rest of file
8 years, 4 months ago (2012-07-31 21:56:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10821118/8001
8 years, 4 months ago (2012-07-31 22:09:57 UTC) #2
commit-bot: I haz the power
Try job failure for 10821118-8001 (retry) on linux_rel for step "nacl_integration". It's a second try, ...
8 years, 4 months ago (2012-07-31 23:32:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10821118/4008
8 years, 4 months ago (2012-08-01 01:17:25 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 02:35:50 UTC) #5
Change committed as 149360

Powered by Google App Engine
This is Rietveld 408576698