Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10821117: disable signed/unsigned mismatch warning in re2 (Closed)

Created:
8 years, 4 months ago by scottmg
Modified:
8 years, 4 months ago
Reviewers:
battre
CC:
chromium-reviews
Visibility:
Public.

Description

disable signed/unsigned mismatch warning in re2 R=battre@chromium.org BUG=126483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/re2/re2.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
battre
I think disabling these warning is reasonable for now. LGTM
8 years, 4 months ago (2012-08-01 11:45:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10821117/1
8 years, 4 months ago (2012-08-01 16:05:13 UTC) #2
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 17:33:30 UTC) #3
Change committed as 149438

Powered by Google App Engine
This is Rietveld 408576698