Rephrase some of the media galleries permission information.

Rephrase some of the media galleries permission information.

BUG=116025
NOTRY=TRUE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149647

[battre, 2012-07-31 21:34:15]

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/mediaGalleries.html (right):

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/mediaGalleries.html:23: permission is
used.</p>
So do you need to request both "mediaGalleriesRead" and
"mediaGalleriesAllGalleries"?

[vandebo (ex-Chrome), 2012-07-31 21:36:06]

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/mediaGalleries.html (right):

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/mediaGalleries.html:23: permission is
used.</p>
On 2012/07/31 21:34:15, battre wrote:
> So do you need to request both "mediaGalleriesRead" and
> "mediaGalleriesAllGalleries"?

To get default access to all well known galleries, yes.  If you only request
"mediaGalleriesRead" then you will start with no access to galleries and will
have to use the runtime dialog to have the user grant permission.

[battre, 2012-07-31 21:47:18]

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/mediaGalleries.html (right):

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/mediaGalleries.html:23: permission is
used.</p>
On 2012/07/31 21:36:06, vandebo wrote:
> On 2012/07/31 21:34:15, battre wrote:
> > So do you need to request both "mediaGalleriesRead" and
> > "mediaGalleriesAllGalleries"?
> 
> To get default access to all well known galleries, yes.  If you only request
> "mediaGalleriesRead" then you will start with no access to galleries and will
> have to use the runtime dialog to have the user grant permission.

Sorry, let me phrase this differently. Do you have read access if you specify
*only* "mediaGalleriesAllGalleries"? Or "Does mediaGalleriesAllGalleries subsume
mediaGalleriesRead"?

[vandebo (ex-Chrome), 2012-07-31 21:50:50]

On 2012/07/31 21:47:18, battre wrote:
>
https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
> File chrome/common/extensions/docs/static/mediaGalleries.html (right):
> 
>
https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
> chrome/common/extensions/docs/static/mediaGalleries.html:23: permission is
> used.</p>
> On 2012/07/31 21:36:06, vandebo wrote:
> > On 2012/07/31 21:34:15, battre wrote:
> > > So do you need to request both "mediaGalleriesRead" and
> > > "mediaGalleriesAllGalleries"?
> > 
> > To get default access to all well known galleries, yes.  If you only request
> > "mediaGalleriesRead" then you will start with no access to galleries and
will
> > have to use the runtime dialog to have the user grant permission.
> 
> Sorry, let me phrase this differently. Do you have read access if you specify
> *only* "mediaGalleriesAllGalleries"? Or "Does mediaGalleriesAllGalleries
subsume
> mediaGalleriesRead"?

You need both permissions.  If you specify only "mediaGalleriesAllGalleries,"
you will get the file system objects for the galleries, but you will get a
permission error from the file system API if you try to read any of the content
(you can read the file system name property only).

This is because eventually we want to have "mediaGalleriesWrite" (read write
permission) and "mediaGalleriesAppend" (no read access, but you can add files).

[battre, 2012-08-01 09:35:47]

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/mediaGalleries.html (right):

https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/mediaGalleries.html:30: </p>
Here is my proposal:
<h2 id="manifest">Manifest</h2>
<p>The media galleries API distinguishes two orthogonal permissions; the access
type (reading, writing, appending files) and the locations in which your
extension may access files. For example:</p>
<pre>{
  "name": "My extension",
  ...
  <b>"permissions": [
    "mediaGalleriesRead",
    "mediaGalleriesAllGalleries"
  ]</b>,
  ...
}</pre>

<p>The "mediaGalleriesRead" permission grants your extension the right to read
files. This permissison does not trigger an install time permission prompt
because the user must still grant access to particular galleries at runtime by
using a directory or file selector dialog.</p>

<p>You may also specify the "mediaGalleriesAllGalleries" permission to get
location access to all auto-detected media galleries on the user's computer. In
this case, access to the all known media galleries does not trigger a file or
directory selector dialog and permission is automatically granted to the degree
specified by the access type (e.g. "mediaGalleriesRead" grants read access). The
"mediaGalleriesAllGalleries" permission displays an install time prompt
indicating that the extension will have access to all of the user's media
files.</p>

<p>Currently "mediaGalleriesRead" is the only access type supported by this API.
Write and append access with be implemented soon.</p>

[vandebo (ex-Chrome), 2012-08-01 17:58:51]

On 2012/08/01 09:35:47, battre wrote:
>
https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
> File chrome/common/extensions/docs/static/mediaGalleries.html (right):
> 
>
https://chromiumcodereview.appspot.com/10821110/diff/1/chrome/common/extensio...
> chrome/common/extensions/docs/static/mediaGalleries.html:30: </p>
> Here is my proposal:

Your text seemed good.  I went to touch up a few minor things, but before I knew
it, I was rewriting and reorganizing most of it, sorry.  One thing I wanted to
do in particular was de-emphasize mediaGalleriesAllGalleries, especially for
someone that was skimming.  Anyway, I hope I kept the things that were important
to you, please push back on anything you don't like.

[battre, 2012-08-02 09:58:58]

Excellent, thanks!

LGTM

[commit-bot: I haz the power, 2012-08-02 16:48:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/10821110/7001

[commit-bot: I haz the power, 2012-08-02 16:48:46]

Presubmit check for 10821110-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/mediaGalleries.html not
reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/common/extensions

Presubmit checks took 6.9s to calculate.

[vandebo (ex-Chrome), 2012-08-02 16:51:40]

+mpcomplete for extension OWNERS

[Matt Perry, 2012-08-02 17:11:51]

lgtm