Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 10821109: Candidate fix for a crash at shutdown when the IO thread is going away. More details in the bug rep… (Closed)

Created:
8 years, 4 months ago by tommi (sloooow) - chröme
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Candidate fix for a crash at shutdown when the IO thread is going away. More details in the bug report. BUG=139790 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149305

Patch Set 1 #

Patch Set 2 : Fix unittest #

Patch Set 3 : Second attempt at fixing tests and also remove from the map inside OnChannelClosing #

Patch Set 4 : Missed the input filter... damn you code duplication! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M content/renderer/media/audio_input_message_filter.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/media/audio_message_filter_unittest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M media/audio/audio_input_device.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/audio/audio_output_device.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
Alas, Murphy showed up. The shutdown sequence is not always the same so I'm adding ...
8 years, 4 months ago (2012-07-31 15:59:19 UTC) #1
scherkus (not reviewing)
lgtm
8 years, 4 months ago (2012-07-31 21:12:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/10821109/4003
8 years, 4 months ago (2012-07-31 21:17:01 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 22:57:40 UTC) #4
Change committed as 149305

Powered by Google App Engine
This is Rietveld 408576698