runtime/vm/flow_graph_builder.cc - Issue 10821108: Ensure that we never try to split range at its end position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10821108: Ensure that we never try to split range at its end position. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index b2924a52924589dff90c835cbd6bfa5465bccc91..43f164360396104b7147d2b0cf63ac82a0308349 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -2636,7 +2636,9 @@ void FlowGraphBuilder::RenameRecursive(BlockEntryInstr* block_entry,

// TODO(fschneider): Currently each instruction gets a full copy of the

// environment. This should be optimized: Only instructions that can

// deoptimize should have uses of the environment values.

- current->set_env(new Environment(*env, fixed_parameter_count));

+ if (!current->IsReturn()) {

Florian Schneider 2012/07/31 15:31:59 This is not part of the fix. I'd remove it.

Vyacheslav Egorov (Google) 2012/07/31 16:18:49 Done.

+ current->set_env(new Environment(*env, fixed_parameter_count));

+ }

// 2a. Handle uses:

// Update expression stack environment for each use.

« runtime/vm/flow_graph_allocator.cc ('K') | « runtime/vm/flow_graph_allocator.cc ('k') | runtime/vm/il_printer.cc » ('j') | runtime/vm/intermediate_language.h » ('J')