Android: remove ant environment dependencies.

Android: remove ant environment dependencies.

The logic to calculate where the SDK should be is already done by
envsetup and made available to gyp as a variable, so just have gyp pass
this as a command line argument to ant. The behaviour is identical.

This change is to move toward making it possible to build the Android
port without having envsetup.sh sourced at build time (only at
gyp-generation time), making it more like other platforms. It also
simplifies the ant buildfiles.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149400

[Torne, 2012-07-31 15:18:26]

Hi folks,

I'm looking at whether we can eliminate the build-time dependency on envsetup,
and this is one of the things that still needs it (building java code). Do you
think this is a reasonable approach?

There are still more issues: building the apks doesn't work without envsetup,
because their buildfiles refer to the environment variables too, in a way that's
less easy to simplify; any thoughts?

[Yaron, 2012-07-31 16:20:50]

lgtm

Ya, I like this. Moves more of the configuration to gyp-time where it should be.
We did the same thing before with baking all the info we need into the
makefiles/ninja files so ant should follow suit.

(aside: this would've been easier after http://codereview.chromium.org/10830012/
but I can adapt (as I'm blocked atm))

[bulach, 2012-07-31 16:28:01]

lgtm, nice, thanks!

[Torne, 2012-08-01 09:49:49]

On 2012/07/31 16:20:50, Yaron wrote:
> (aside: this would've been easier after
http://codereview.chromium.org/10830012/
> but I can adapt (as I'm blocked atm))

Sorry, I had this ready to go :)

[commit-bot: I haz the power, 2012-08-01 09:49:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/10821105/1

[commit-bot: I haz the power, 2012-08-01 09:50:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/10821105/1

[commit-bot: I haz the power, 2012-08-01 11:31:48]

Change committed as 149400