Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10821103: Make 'License' field in third-party metadata required (Closed)

Created:
8 years, 4 months ago by Steve Block
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai, Nico, agl, brettw
CC:
chromium-reviews, erikwright (departed), Paweł Hajdan Jr., kkania, darin-cc_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Make 'License' field in third-party metadata required This will simplify the addition of a tool to check licenses for the purpose of the Android WebView build. See also http://codereview.chromium.org/10827099 Also adds other missing fields to these README.chromium files as required by presubmit checks and fixes a regex used to enforce this. BUG=138921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149423

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed comments #

Patch Set 3 : Removed controversial changes #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -10 lines) Patch
M base/third_party/dmg_fp/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/dynamic_annotations/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/nspr/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/symbolize/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/xdg_user_dirs/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/third_party/jstemplate/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/third_party/mock4js/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/third_party/nss/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/PRESUBMIT.py View 3 chunks +11 lines, -2 lines 0 comments Download
third_party/README.chromium.template View 2 chunks +2 lines, -2 lines 0 comments Download
third_party/active_doc/README.chromium View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/apple_apsl/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/apple_sample_code/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/apple_webkit/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/ashmem/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/bsdiff/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/bspatch/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/bzip2/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/cld/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/codesighs/README.chromium View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/devscripts/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
third_party/gles2_book/README.chromium View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/gtk+/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/hyphen/README.chromium View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/iccjpeg/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/isimpledom/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/jemalloc/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/launchpad_translations/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/lcov/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libjpeg/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
third_party/libpng/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
third_party/libva/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxslt/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/lzma_sdk/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/modp_b64/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mongoose/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mozilla/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
third_party/npapi/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/ply/README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/protobuf/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/pyftpdlib/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/qcms/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
third_party/skia/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/sqlite/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/swig/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/talloc/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/tcmalloc/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tlslite/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/webdriver/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/wtl/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/zlib/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M tools/licenses.py View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
Did you want me to look at the actual licenses? I just skimmed and checked ...
8 years, 4 months ago (2012-07-31 14:30:39 UTC) #1
Steve Block
Thanks Nico. Your comments have made me doubt the accuracy of the existing license files. ...
8 years, 4 months ago (2012-07-31 15:18:14 UTC) #2
Steve Block
I checked over all licenses and found a couple of other cases where the existing ...
8 years, 4 months ago (2012-07-31 18:01:43 UTC) #3
Nico
Do you want me to double-check all License: lines, or is a "looks about right" ...
8 years, 4 months ago (2012-07-31 18:04:32 UTC) #4
Steve Block
I've just double-checked them all, and all the licenses added here match their corresponding license ...
8 years, 4 months ago (2012-07-31 18:06:51 UTC) #5
Nico
lgtm
8 years, 4 months ago (2012-07-31 18:14:26 UTC) #6
Steve Block
Thanks. Did you see the sister change to deps/ - http://codereview.chromium.org/10827099 ?
8 years, 4 months ago (2012-08-01 00:06:05 UTC) #7
Steve Block
+agl, brettw for OWNERS
8 years, 4 months ago (2012-08-01 14:43:29 UTC) #8
agl
lgtm
8 years, 4 months ago (2012-08-01 14:47:06 UTC) #9
Mark Mentovai
LGTM for base OWNERS review.
8 years, 4 months ago (2012-08-01 15:46:08 UTC) #10
brettw
8 years, 4 months ago (2012-08-01 21:27:54 UTC) #11 
I don't think you need me, please ping me if you do.

Powered by Google App Engine
This is Rietveld 408576698