Issue 10821098: Heapchecker: Raise timeout value from 20 to 30 minutes. TSAN: Add another suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10821098: Heapchecker: Raise timeout value from 20 to 30 minutes. TSAN: Add another suppression. (Closed)

Created:
8 years, 4 months ago by Lei Zhang

Modified:
8 years, 4 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Heapchecker: Raise timeout value from 20 to 30 minutes. TSAN: Add another suppression. BUG=137973 TEST=none TBR=glider Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149077

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	tools/heapcheck/heapcheck_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/tsan/suppressions.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

In tools/heapcheck/heapcheck_test.py, we have always had a 1200 second timeout. This was fine since most ...

8 years, 4 months ago (2012-07-30 23:42:33 UTC) #1

Alexander Potapenko

8 years, 4 months ago (2012-07-31 10:52:40 UTC) #2

I think it's just fine to leave Pipeline::SetState and delete all the frames
below.
LGTM otherwise.