Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 10821089: Add the save_package_browsertest.cc to content_browsertests. (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Add the save_package_browsertest.cc to content_browsertests. Also move mouseleave_browsertest.cc to src\chrome. This is an interactive_ui_tests, and while we can theoretically create another content_browsertest target for interactive tests, it seems pointless for just one test. So run it as part of chrome. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148970

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -95 lines) Patch
A + chrome/browser/mouseleave_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/download/save_package_browsertest.cc View 1 3 chunks +14 lines, -15 lines 0 comments Download
D content/browser/mouseleave_browsertest.cc View 1 1 chunk +0 lines, -80 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
this depends on http://codereview.chromium.org/10829070/ landing first, because of the fix in the ShellDownloadManagerDelegate
8 years, 4 months ago (2012-07-30 17:13:27 UTC) #1
scottmg
8 years, 4 months ago (2012-07-30 17:16:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698