Issue 10821087: Fix color chooser cleanup process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10821087: Fix color chooser cleanup process. (Closed)

Created:
8 years, 4 months ago by Jun Mukai

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix color chooser cleanup process. - In case of crbug.com/139441, End() should close the window but it also schedules OnColorChooserDialogClosed() and this has been released already. That call isn't necessary in this case, so set_listener to NULL. - tab is expected to call DidEndColorChooser() everytime it ends, thus it should be called in End() too. the callback to prevent the calling BUG=139441 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149380

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
M	chrome/browser/ui/views/color_chooser_aura.cc	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	ui/views/color_chooser/color_chooser_view.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/color_chooser/color_chooser_view.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10821087/2001

8 years, 4 months ago (2012-08-01 04:39:25 UTC) #3

Change committed as 149380

Expand Messages | Collapse Messages