Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10821085: mac: Remove one static initializer. (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

mac: Remove one static initializer. The NSAccessibility* strings are not defined, only declared, in NSAccessibility.h, so the compiler needs to emit a static initializer if they are used in a global initializer. BUG=94925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148914

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -41 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 2 chunks +39 lines, -41 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Nico
First to review wins!
8 years, 4 months ago (2012-07-29 06:07:54 UTC) #1
Nico
https://chromiumcodereview.appspot.com/10821085/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm File content/browser/accessibility/browser_accessibility_cocoa.mm (right): https://chromiumcodereview.appspot.com/10821085/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode248 content/browser/accessibility/browser_accessibility_cocoa.mm:248: + (void)initialize { (+initialize methods are effectively static initializers ...
8 years, 4 months ago (2012-07-29 06:09:06 UTC) #2
dmazzoni
lgtm Great. I could be wrong, but I think this is even better that you ...
8 years, 4 months ago (2012-07-29 06:30:45 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-29 15:47:48 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698