Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10821083: views: Enable ViewTest.RemoveNotification on Linux. (Closed)

Created:
8 years, 4 months ago by tfarina
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

views: Enable ViewTest.RemoveNotification on Linux. BUG=139083 R=ben@chromium.org NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148950

Patch Set 1 #

Patch Set 2 : rm TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M ui/views/view_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
It passed locally (Linux with chromeos=1) and on linux_chromeos. Do we need to test it ...
8 years, 4 months ago (2012-07-28 21:38:53 UTC) #1
Ben Goodger (Google)
lgtm On Sat, Jul 28, 2012 at 2:38 PM, <tfarina@chromium.org> wrote: > Reviewers: Ben Goodger ...
8 years, 4 months ago (2012-07-28 21:43:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10821083/7001
8 years, 4 months ago (2012-07-30 14:31:20 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 14:31:29 UTC) #4
Change committed as 148950

Powered by Google App Engine
This is Rietveld 408576698