Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 10821081: Move 'mdat' advancement logic to make more sense. (Closed)

Created:
8 years, 4 months ago by strobe_
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Move 'mdat' advancement logic to make more sense. This defers the change from kEmittingSamples to kParsingBoxes until after the current 'mdat' atom has been cleared in MP4StreamParser. BUG= TEST=MP4StreamParserTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148977

Patch Set 1 #

Patch Set 2 : Fix all the grammars #

Total comments: 2

Patch Set 3 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M media/mp4/mp4_stream_parser.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
strobe_
Another tiny CL with almost no semantic impact. If these changes are too trivial to ...
8 years, 4 months ago (2012-07-28 06:07:39 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM % nit http://codereview.chromium.org/10821081/diff/3001/media/mp4/mp4_stream_parser.cc File media/mp4/mp4_stream_parser.cc (right): http://codereview.chromium.org/10821081/diff/3001/media/mp4/mp4_stream_parser.cc#newcode323 media/mp4/mp4_stream_parser.cc:323: if (!queue_.Trim(mdat_tail_)) return false; nit: Put ...
8 years, 4 months ago (2012-07-30 15:45:49 UTC) #2
strobe_
http://codereview.chromium.org/10821081/diff/3001/media/mp4/mp4_stream_parser.cc File media/mp4/mp4_stream_parser.cc (right): http://codereview.chromium.org/10821081/diff/3001/media/mp4/mp4_stream_parser.cc#newcode323 media/mp4/mp4_stream_parser.cc:323: if (!queue_.Trim(mdat_tail_)) return false; On 2012/07/30 15:45:50, acolwell wrote: ...
8 years, 4 months ago (2012-07-30 16:33:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10821081/6002
8 years, 4 months ago (2012-07-30 16:33:51 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 18:16:59 UTC) #5
Change committed as 148977

Powered by Google App Engine
This is Rietveld 408576698