Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6299)

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 10821077: Add gallery permissions to Media Galleries Preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs.cc
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc
index 3437643a4d4ab5b8b1688ad08ba7fd30a844d527..ffb0497b36116c91001a5b03319c2fb8b3c02725 100644
--- a/chrome/browser/extensions/extension_prefs.cc
+++ b/chrome/browser/extensions/extension_prefs.cc
@@ -1163,7 +1163,7 @@ namespace {
bool GetMediaGalleryPermissionFromDictionary(
const DictionaryValue* dict,
- MediaGalleryPermission* out_permission) {
+ chrome::MediaGalleryPermission* out_permission) {
std::string string_id;
if (dict->GetString(kMediaGalleryIdKey, &string_id) &&
base::StringToUint64(string_id, &out_permission->pref_id) &&
@@ -1175,9 +1175,10 @@ bool GetMediaGalleryPermissionFromDictionary(
return false;
}
-void RemoveMediaGalleryPermissionsFromExtension(PrefService* prefs,
- const std::string& extension_id,
- MediaGalleryPrefId gallery_id) {
+void RemoveMediaGalleryPermissionsFromExtension(
+ PrefService* prefs,
+ const std::string& extension_id,
+ chrome::MediaGalleryPrefId gallery_id) {
ScopedExtensionPrefUpdate update(prefs, extension_id);
DictionaryValue* extension_dict = update.Get();
ListValue* permissions = NULL;
@@ -1190,7 +1191,7 @@ void RemoveMediaGalleryPermissionsFromExtension(PrefService* prefs,
const DictionaryValue* dict = NULL;
if (!(*it)->GetAsDictionary(&dict))
continue;
- MediaGalleryPermission perm;
+ chrome::MediaGalleryPermission perm;
if (!GetMediaGalleryPermissionFromDictionary(dict, &perm))
continue;
if (perm.pref_id == gallery_id) {
@@ -1202,9 +1203,10 @@ void RemoveMediaGalleryPermissionsFromExtension(PrefService* prefs,
} // namespace
-void ExtensionPrefs::SetMediaGalleryPermission(const std::string& extension_id,
- MediaGalleryPrefId gallery,
- bool has_access) {
+void ExtensionPrefs::SetMediaGalleryPermission(
+ const std::string& extension_id,
+ chrome::MediaGalleryPrefId gallery,
+ bool has_access) {
ScopedExtensionPrefUpdate update(prefs_, extension_id);
DictionaryValue* extension_dict = update.Get();
ListValue* permissions = NULL;
@@ -1219,7 +1221,7 @@ void ExtensionPrefs::SetMediaGalleryPermission(const std::string& extension_id,
DictionaryValue* dict = NULL;
if (!(*it)->GetAsDictionary(&dict))
continue;
- MediaGalleryPermission perm;
+ chrome::MediaGalleryPermission perm;
if (!GetMediaGalleryPermissionFromDictionary(dict, &perm))
continue;
if (perm.pref_id == gallery) {
@@ -1235,9 +1237,15 @@ void ExtensionPrefs::SetMediaGalleryPermission(const std::string& extension_id,
permissions->Append(dict);
}
-std::vector<MediaGalleryPermission> ExtensionPrefs::GetMediaGalleryPermissions(
- const std::string& extension_id) {
- std::vector<MediaGalleryPermission> result;
+void ExtensionPrefs::UnsetMediaGalleryPermission(
+ const std::string& extension_id,
+ chrome::MediaGalleryPrefId gallery) {
+ RemoveMediaGalleryPermissionsFromExtension(prefs_, extension_id, gallery);
+}
+
+std::vector<chrome::MediaGalleryPermission>
+ExtensionPrefs::GetMediaGalleryPermissions(const std::string& extension_id) {
+ std::vector<chrome::MediaGalleryPermission> result;
const ListValue* permissions = NULL;
if (ReadExtensionPrefList(extension_id, kMediaGalleriesPermissions,
&permissions)) {
@@ -1247,7 +1255,7 @@ std::vector<MediaGalleryPermission> ExtensionPrefs::GetMediaGalleryPermissions(
DictionaryValue* dict = NULL;
if (!(*it)->GetAsDictionary(&dict))
continue;
- MediaGalleryPermission perm;
+ chrome::MediaGalleryPermission perm;
if (!GetMediaGalleryPermissionFromDictionary(dict, &perm))
continue;
result.push_back(perm);
@@ -1257,7 +1265,7 @@ std::vector<MediaGalleryPermission> ExtensionPrefs::GetMediaGalleryPermissions(
}
void ExtensionPrefs::RemoveMediaGalleryPermissions(
- MediaGalleryPrefId gallery_id) {
+ chrome::MediaGalleryPrefId gallery_id) {
const DictionaryValue* extensions = prefs_->GetDictionary(kExtensionsPref);
if (!extensions)
return;

Powered by Google App Engine
This is Rietveld 408576698