Issue 10821071: aura-flash: Fix a crash when touching a fullscreen flash window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10821071: aura-flash: Fix a crash when touching a fullscreen flash window. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura-flash: Fix a crash when touching a fullscreen flash window. BUG=136446 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149424

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 4 months ago (2012-07-31 15:39:27 UTC) #2

LGTM


On Fri, Jul 27, 2012 at 1:29 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> aura-flash: Fix a crash when touching a fullscreen flash window.
>
> BUG=136446
>
>
> Please review this at
http://codereview.chromium.**org/10821071/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M content/browser/renderer_host/**render_widget_host_view_aura.**cc
>
>
> Index: content/browser/renderer_host/**render_widget_host_view_aura.**cc
> diff --git
a/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> b/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> index af529590ca7c7498fcdd3449bf67da**13467b7208..**
> b1d52334146d005d7777aa78d7fe7e**4a57c69339 100644
> --- a/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> +++ b/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> @@ -1291,7 +1291,7 @@ ui::GestureStatus RenderWidgetHostViewAura::**
> OnGestureEvent(
>    }
>
>    RenderViewHostDelegate* delegate = NULL;
> -  if (popup_type_ == WebKit::WebPopupTypeNone)
> +  if (popup_type_ == WebKit::WebPopupTypeNone && !is_fullscreen_)
>      delegate = RenderViewHost::From(host_)->**GetDelegate();
>    if (delegate && event->type() == ui::ET_GESTURE_BEGIN &&
>        event->details().touch_points(**) == 1) {
>
>
>

Expand Messages | Collapse Messages