Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 10821069: Moving file_metadata files under content/browser/download (Closed)

Created:
8 years, 4 months ago by cristian.patrasciuc
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Moving file_metadata files under content/browser/download Some cleanup of the file_metadata files (especially for Mac OS). I moved them under content/browser/download and changed the namespace to "content" to match the Linux implementation and the style guide. I also included a small change to the Linux-related unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148910

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Git-based patch to overcome the 'svn mv' problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -234 lines) Patch
M content/browser/download/base_file.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/download/file_metadata_linux.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/file_metadata_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/download/file_metadata_mac.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/download/file_metadata_mac.mm View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/file_metadata_unittest_linux.cc View 1 2 4 chunks +19 lines, -21 lines 0 comments Download
D content/browser/file_metadata_mac.h View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D content/browser/file_metadata_mac.mm View 1 2 1 chunk +0 lines, -168 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
cristian.patrasciuc
I uploaded a separate patch to move some files under new folders/namespaces as I said ...
8 years, 4 months ago (2012-07-27 17:06:30 UTC) #1
darin (slow to review)
LGTM, thanks!!
8 years, 4 months ago (2012-07-27 17:15:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cristian.patrasciuc@gmail.com/10821069/1
8 years, 4 months ago (2012-07-27 17:22:34 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/browser/download/file_metadata_mac.h: While running patch -p0 --forward --force; patching file content/browser/download/file_metadata_mac.h ...
8 years, 4 months ago (2012-07-27 17:22:42 UTC) #4
cristian.patrasciuc
I moved the files using "svn mv". Should I have used something else? I think ...
8 years, 4 months ago (2012-07-27 17:28:33 UTC) #5
darin (slow to review)
Perhaps you need to run "svn update" and then re-upload the patch. -Darin On Fri, ...
8 years, 4 months ago (2012-07-27 17:30:15 UTC) #6
cristian.patrasciuc
Done.
8 years, 4 months ago (2012-07-27 17:33:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cristian.patrasciuc@gmail.com/10821069/9001
8 years, 4 months ago (2012-07-27 17:44:42 UTC) #8
commit-bot: I haz the power
Failed to apply patch for content/browser/download/file_metadata_mac.h: While running patch -p0 --forward --force; patching file content/browser/download/file_metadata_mac.h ...
8 years, 4 months ago (2012-07-27 17:44:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cristian.patrasciuc@gmail.com/10821069/2004
8 years, 4 months ago (2012-07-28 21:58:31 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-07-28 23:22:58 UTC) #11
Change committed as 148910

Powered by Google App Engine
This is Rietveld 408576698