Issue 10821068: Revert 148720 - [Web Intents] Localization of intent titles for CWS suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10821068: Revert 148720 - [Web Intents] Localization of intent titles for CWS suggestions (Closed)

Created:
8 years, 4 months ago by zhaoqin1

Modified:
8 years, 4 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jshin+watch_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 148720 - [Web Intents] Localization of intent titles for CWS suggestions R=mpcomplete@chromium.org,gbillock@chromium.org BUG=130432 TEST=CWSIntentsRegistryTest.LocalizeMatchingLocale:ExtensionL10nUtil.GetAllFallbackLocales:ExtensionL10nUtil.LoadMessageCatalogs* Review URL: https://chromiumcodereview.appspot.com/10790087 TBR=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148751

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -227 lines)			Patch
M	chrome/browser/intents/cws_intents_registry.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/intents/cws_intents_registry.cc	View	3 chunks	+0 lines, -45 lines	0 comments	Download
M	chrome/browser/intents/cws_intents_registry_unittest.cc	View	6 chunks	+29 lines, -151 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.cc	View	2 chunks	+4 lines, -11 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util_unittest.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages