Issue 10821066: Revert 148377 - [Android] Upstream additional changes from envsetup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10821066: Revert 148377 - [Android] Upstream additional changes from envsetup. (Closed)

Created:
8 years, 4 months ago by Peter Beverloo

Modified:
8 years, 4 months ago

Reviewers:
Yaron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 148377 - [Android] Upstream additional changes from envsetup. This broke the Android WebKit bots as they switched to using Ninja, which should have been tested before this landed. --- Splits helper functions out of envsetup into envsetup_functions.sh. Also includes device helper functions in build/android/adb_device_functions.sh. Finally, some fixes to build/common.gypi that happened when cherry-picked down https://chromiumcodereview.appspot.com/10807019 BUG=137569, 136693 Review URL: https://chromiumcodereview.appspot.com/10796104 TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148739

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -485 lines)			Patch
D	build/android/adb_device_functions.sh	View	1 chunk	+0 lines, -133 lines	0 comments	Download
M	build/android/envsetup.sh	View	4 chunks	+108 lines, -53 lines	0 comments	Download
D	build/android/envsetup_functions.sh	View	1 chunk	+0 lines, -292 lines	0 comments	Download
M	build/common.gypi	View	4 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)