Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 10821065: Add Drive API specific operations. (Closed)

Created:
8 years, 4 months ago by kochi
Modified:
8 years, 4 months ago
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1, Daniel Erat
Visibility:
Public.

Description

Add Drive API specific operations. Future CLs will use these operations. BUG=chromium:127728 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148727

Patch Set 1 : . #

Total comments: 4

Patch Set 2 : update for comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
A chrome/browser/chromeos/gdata/drive_api_operations.h View 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/drive_api_operations.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_documents_service.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_documents_service.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_gdata_documents_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
Ryo, could you review?
8 years, 4 months ago (2012-07-27 06:34:22 UTC) #1
hashimoto
http://codereview.chromium.org/10821065/diff/2001/chrome/browser/chromeos/gdata/drive_api_operations.cc File chrome/browser/chromeos/gdata/drive_api_operations.cc (right): http://codereview.chromium.org/10821065/diff/2001/chrome/browser/chromeos/gdata/drive_api_operations.cc#newcode38 chrome/browser/chromeos/gdata/drive_api_operations.cc:38: : GetDataOperation(registry, profile, callback) {} nit: Please insert a ...
8 years, 4 months ago (2012-07-27 06:48:37 UTC) #2
kochi
http://codereview.chromium.org/10821065/diff/2001/chrome/browser/chromeos/gdata/drive_api_operations.cc File chrome/browser/chromeos/gdata/drive_api_operations.cc (right): http://codereview.chromium.org/10821065/diff/2001/chrome/browser/chromeos/gdata/drive_api_operations.cc#newcode38 chrome/browser/chromeos/gdata/drive_api_operations.cc:38: : GetDataOperation(registry, profile, callback) {} On 2012/07/27 06:48:37, hashimoto ...
8 years, 4 months ago (2012-07-27 06:56:58 UTC) #3
hashimoto
lgtm
8 years, 4 months ago (2012-07-27 06:59:53 UTC) #4
kochi
On 2012/07/27 06:59:53, hashimoto wrote: > lgtm Thanks, added TBR=ben@chromium.org for chrome/chrome_browser.gypi
8 years, 4 months ago (2012-07-27 07:05:55 UTC) #5
Ben Goodger (Google)
8 years, 4 months ago (2012-07-27 17:12:53 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698