Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10821062: Fix CleanupProcesses() interface to use TimeDelta. (Closed)

Created:
8 years, 5 months ago by Ted Vessenes
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), grt+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix CleanupProcesses() interface to use TimeDelta. BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M base/process_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_posix.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M base/process_util_win.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/mini_installer_test/test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted Vessenes
jar@chromium.org: Please review base/* sky@chromium.org: Please review chrome/*
8 years, 5 months ago (2012-07-27 04:36:21 UTC) #1
jar (doing other things)
base/* LGTM
8 years, 4 months ago (2012-07-27 16:41:26 UTC) #2
Ted Vessenes
jam@chromium.org: Can you review chrome/* for me?
8 years, 4 months ago (2012-07-31 13:24:09 UTC) #3
jam
lgtm
8 years, 4 months ago (2012-07-31 15:35:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10821062/1
8 years, 4 months ago (2012-07-31 15:36:15 UTC) #5
commit-bot: I haz the power
Try job failure for 10821062-1 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-07-31 18:51:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10821062/1
8 years, 4 months ago (2012-07-31 22:05:58 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 23:22:49 UTC) #8 
Change committed as 149312

Powered by Google App Engine
This is Rietveld 408576698