Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 10821059: Add done-clicked notification to content settings bubble model. (Closed)

Created:
8 years, 5 months ago by Greg Billock
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add done-clicked notification to content settings bubble model. Add RPH use for said notification to clear the setting affordance from the location bar. R=bauerb@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Greg Billock
8 years, 5 months ago (2012-07-27 01:13:39 UTC) #1
Greg Billock
On 2012/07/27 01:13:39, Greg Billock wrote: ping
8 years, 4 months ago (2012-07-30 16:46:34 UTC) #2
Bernhard Bauer
LGTM
8 years, 4 months ago (2012-07-30 16:55:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10821059/1
8 years, 4 months ago (2012-07-30 18:36:16 UTC) #4
commit-bot: I haz the power
Presubmit check for 10821059-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 18:36:20 UTC) #5
Greg Billock
On 2012/07/30 18:36:20, I haz the power (commit-bot) wrote: > Presubmit check for 10821059-1 failed ...
8 years, 4 months ago (2012-07-30 19:10:29 UTC) #6
Elliot Glaysher
gtk lgtm
8 years, 4 months ago (2012-07-30 23:25:22 UTC) #7
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-31 15:39:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10821059/1
8 years, 4 months ago (2012-07-31 15:42:04 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 17:10:23 UTC) #10
Change committed as 149210

Powered by Google App Engine
This is Rietveld 408576698