Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 10821054: Aura: Compensate for round-off error in damage. (Closed)

Created:
8 years, 4 months ago by jonathan.backer
Modified:
8 years, 4 months ago
Reviewers:
jam, oshima, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Aura: Compensate for round-off error in damage. We get sub-DIP damage from the renderer with --ui-enable-partial-swap. When we convert to DIP in RWHVA::AccelerateSurfacePostSubBuffers, we trancate that damage (an shrink the rect). The straightforward solution is to assume that the damage was truncated and dilate the DIP damage rect. BUG=139208 TEST=by hand on device that supports --ui-enable-partial-swap Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148800

Patch Set 1 #

Patch Set 2 : Rebase and clip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jonathan.backer
8 years, 4 months ago (2012-07-26 22:00:56 UTC) #1
oshima
lgtm
8 years, 4 months ago (2012-07-26 22:14:53 UTC) #2
jonathan.backer
+sky for OWNERS
8 years, 4 months ago (2012-07-26 22:18:06 UTC) #3
jam
lgtm
8 years, 4 months ago (2012-07-27 16:47:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/10821054/3002
8 years, 4 months ago (2012-07-27 18:15:07 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 20:48:09 UTC) #6
Change committed as 148800

Powered by Google App Engine
This is Rietveld 408576698