gdata: Add File System Contents section to chrome:drive-internals

gdata: Add File System Contents section to chrome:drive-internals

This section is used to show metadata of the file system as pre-formatted
text. We could make it prettier, but pre-formatted text should be sufficient
for developers.

BUG=135328
TEST=the new section is shown in chrome:drive-internals properly

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148759

[satorux1, 2012-07-26 21:21:51]

yoshiki@, this will be also useful for testing your "nuke everything" feature.

[achuithb, 2012-07-26 23:00:23]

lgtm

http://codereview.chromium.org/10821051/diff/1/chrome/browser/ui/webui/chrome...
File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right):

http://codereview.chromium.org/10821051/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:161: void
OnReadDirectoryByPath(
I think it's more readable to split the definitions and declarations instead of
inlining the definitions. It makes it easy to see what functions a class has and
it's easier to figure out where the class definition starts and ends. 

I think there was a thread on chromium-dev about this being the preferred
pattern. But I leave it to you.

[satorux1, 2012-07-27 16:13:44]

http://codereview.chromium.org/10821051/diff/1/chrome/browser/ui/webui/chrome...
File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right):

http://codereview.chromium.org/10821051/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:161: void
OnReadDirectoryByPath(
On 2012/07/26 23:00:23, achuith.bhandarkar wrote:
> I think it's more readable to split the definitions and declarations instead
of
> inlining the definitions. It makes it easy to see what functions a class has
and
> it's easier to figure out where the class definition starts and ends. 
> 
> I think there was a thread on chromium-dev about this being the preferred
> pattern. But I leave it to you.

Done.

http://codereview.chromium.org/10821051/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:194: std::string
FormatEntry(const FilePath& path,
moved this out of the class.

http://codereview.chromium.org/10821051/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:249: std::string
file_system_as_text_;
removed this.  instead of sending the entire file system contents, we can just
feed contents of a directory to javascript side, which is much more efficient